Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add history query #354

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add history query #354

wants to merge 3 commits into from

Conversation

cffan
Copy link

@cffan cffan commented Jun 4, 2021

No description provided.

@coveralls
Copy link

coveralls commented Jun 4, 2021

Pull Request Test Coverage Report for Build 1401

  • 48 of 51 (94.12%) changed or added relevant lines in 7 files are covered.
  • 39 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.05%) to 77.616%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/compiler/ops.ts 6 7 85.71%
lib/ast/expression.ts 14 16 87.5%
Files with Coverage Reduction New Missed Lines %
lib/new-syntax/parser.ts 39 73.6%
Totals Coverage Status
Change from base Build 1399: 0.05%
Covered Lines: 10228
Relevant Lines: 12666

💛 - Coveralls

Copy link
Contributor

@gcampax gcampax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks ok. You might want to add a compiler and runtime test to be sure.

Another thing I'm wondering about, rather than removing input arguments, we might want to turn them into output arguments, because we'll definitely want to search for history records where we passed certain inputs to a function.

lib/ast/expression.ts Outdated Show resolved Hide resolved
lib/typecheck.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@gcampax gcampax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we merge this while we work on the Genie side?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants