-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add history query #354
base: master
Are you sure you want to change the base?
Add history query #354
Conversation
Pull Request Test Coverage Report for Build 1401
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks ok. You might want to add a compiler and runtime test to be sure.
Another thing I'm wondering about, rather than removing input arguments, we might want to turn them into output arguments, because we'll definitely want to search for history records where we passed certain inputs to a function.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we merge this while we work on the Genie side?
No description provided.