Fix dspy Module's deepcopy #1519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenmoneygithub
force-pushed
the
fix-reset-copy
branch
from
8bd7e6a to
df859ad
Compare
okhat
reviewed
Sep 21, 2024
dspy/primitives/module.py
Outdated
| for attr, value in self.__dict__.items(): | ||
| if isinstance(value, BaseModule): | ||
| try: | ||
| # Try deep copying the module to reduce recursion depth. |
There was a problem hiding this comment.
good catch, I should remove this part.
|
This ... is probably OK? Do we want to issue a warning on the first deepcopy that faces trouble and tell the user about it? I worry about silent bugs. People do expect deep copy to give them a real deep copy, but maybe we can explain that it only guarantees a deep copy of DSPy-related attributes. |
|
@okhat Yea I think that would be fine, but I will keep monitoring if this is causing trouble for users. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current solution has issues if
dspy.BaseModulecontains non-copyable instances. The proposed approach is:BaseModule, try deep copying, if failed then do recursive call.BaseModule, try deep copying, if failed try shallow copying, if still failed just copying over the reference.BaseModule, the recursion stops.Added unit tests to test it.