Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for more types #1900

Merged
merged 6 commits into from
Dec 9, 2024
Merged

Added support for more types #1900

merged 6 commits into from
Dec 9, 2024

Conversation

thomasahle
Copy link
Collaborator

Adds support for all python ast types in string signatures, like Signature("text -> label:Literal['a', 'b']").
Fixes #1899

@thomasahle
Copy link
Collaborator Author

Ah, I forgot it needs to work in Python 3.9.
NoneType was only added in 3.10:
https://docs.python.org/3/library/types.html#types.NoneType

@thomasahle thomasahle merged commit 00d4f69 into stanfordnlp:main Dec 9, 2024
4 checks passed
isaacbmiller pushed a commit that referenced this pull request Dec 11, 2024
@thomasahle @isaacbmiller
Added support for more types (#1900)
6064015 
* Added support for more types
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isaacbmiller isaacbmiller Awaiting requested review from isaacbmiller

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support more ast types in Signature typed parsing
1 participant
@thomasahle