Caching: Use reentrant locks, don't discard callables (or any other unhashable object in the future) from the cache key #1905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbczumar
commented
Dec 8, 2024
dspy/clients/lm.py
Outdated
Comment on lines
254
to
255
| try: | ||
| return hash(value) |
There was a problem hiding this comment.
Most functions appear to be hashable. This is tested in test_lm.py
dbczumar
commented
Dec 8, 2024
dspy/clients/lm.py
Outdated
Comment on lines
283
to
285
| # If the cache key cannot be computed (e.g. because it contains an unhahsable | ||
| # value), fall back to the uncached version of the function | ||
| return func(request, *args, **kwargs) |
There was a problem hiding this comment.
@okhat Let me know if you think we should print a warning here, since falling back to the disk cache is slower.
Signed-off-by: dbczumar <corey.zumar@databricks.com>
Signed-off-by: dbczumar <corey.zumar@databricks.com>
isaacbmiller
pushed a commit
that referenced
this pull request
Dec 11, 2024
…nhashable object in the future) from the cache key (#1905) * fix Signed-off-by: dbczumar <corey.zumar@databricks.com> * fix Signed-off-by: dbczumar <corey.zumar@databricks.com> * fix Signed-off-by: dbczumar <corey.zumar@databricks.com> * fix Signed-off-by: dbczumar <corey.zumar@databricks.com> * Fallback Signed-off-by: dbczumar <corey.zumar@databricks.com> * fix Signed-off-by: dbczumar <corey.zumar@databricks.com> * fix Signed-off-by: dbczumar <corey.zumar@databricks.com> * fix Signed-off-by: dbczumar <corey.zumar@databricks.com> * fix Signed-off-by: dbczumar <corey.zumar@databricks.com> * fix Signed-off-by: dbczumar <corey.zumar@databricks.com> * fix Signed-off-by: dbczumar <corey.zumar@databricks.com> * fix Signed-off-by: dbczumar <corey.zumar@databricks.com> * fix Signed-off-by: dbczumar <corey.zumar@databricks.com> * fix Signed-off-by: dbczumar <corey.zumar@databricks.com> * Test Signed-off-by: dbczumar <corey.zumar@databricks.com> * fix Signed-off-by: dbczumar <corey.zumar@databricks.com> * Debug Signed-off-by: dbczumar <corey.zumar@databricks.com> * Debug Signed-off-by: dbczumar <corey.zumar@databricks.com> * Debug Signed-off-by: dbczumar <corey.zumar@databricks.com> * fix Signed-off-by: dbczumar <corey.zumar@databricks.com> * progress Signed-off-by: dbczumar <corey.zumar@databricks.com> * Test no cache Signed-off-by: dbczumar <corey.zumar@databricks.com> * Test no cache Signed-off-by: dbczumar <corey.zumar@databricks.com> * fix Signed-off-by: dbczumar <corey.zumar@databricks.com> --------- Signed-off-by: dbczumar <corey.zumar@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caching: Use reentrant locks, don't discard callables (or any other unhashable object in the future) from the cache key