Skip to content
This repository has been archived by the owner on Nov 18, 2021. It is now read-only.

Upgrade spoon runner, gradle tools, fix example lollipop screenshots #44

Merged
merged 1 commit into from
Mar 17, 2015

Conversation

edenman
Copy link
Contributor

@edenman edenman commented Mar 16, 2015

No description provided.

@edenman edenman force-pushed the master branch 2 times, most recently from 004503b to d89ad19 Compare March 16, 2015 21:09
@edenman
Copy link
Contributor Author

edenman commented Mar 16, 2015

@roman-mazur thoughts?


compile 'com.android.tools.build:gradle:0.14.1'
compile 'com.android.tools.build:gradle:1.0.0'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not the latest one? 1.1.3?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't remember the error but I had a problem in my project when I went up to 1.1

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lemme see if I can repro now

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could be a conflict with guava when you run a lint task from gradle (for example, with ./gradlew check).
#33

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, wasn't that (saw that in the readme). It's a conflict with the android-unit-test plugin. Trying to resolve now.

@edenman
Copy link
Contributor Author

edenman commented Mar 17, 2015

Updated, PTAL

@roman-mazur
Copy link
Contributor

And how was the conflict resolved?

@edenman
Copy link
Contributor Author

edenman commented Mar 17, 2015

The official plugin added unit tests support in 1.1, breaking the unofficial android-unit-test plugin I was using (https://github.com/JCAndKSolutions/android-unit-test). I also had to do some gradle transitive dependency exclusion (com.google.code.findbugs from espresso-core and com.android.support from assertj-android).

roman-mazur added a commit that referenced this pull request Mar 17, 2015
Upgrade spoon runner, gradle tools, fix example lollipop screenshots
@roman-mazur roman-mazur merged commit ac7c23c into stanfy:master Mar 17, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants