Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support initial specification of centroids #2

Merged
merged 3 commits into from
Feb 24, 2018

Conversation

colinscape
Copy link
Contributor

@colinscape colinscape commented Feb 24, 2018

Hi there - found you on npm and the package is incredibly easy to use - thanks so much for creating it.

One thing I was looking for was a way to specify the initial centroids, mainly as a way to remove the randomness and to build up the centroids over time.

Would love your thoughts on this change - I know you have "enhance initial centroid picking" as a To-Do item - so maybe this could be a first step towards that?

@stanleyfok
Copy link
Owner

Hi Colin,

Thanks for your supporting! 👍 It is a good idea to provide an option to put initial centroids! Let me merge your PR.

I was looking at kmeans++, which seems a better way to pick initial centroids, but I've got not much time recently to study it, as I am still new to machine learning algorithms :)

@stanleyfok stanleyfok merged commit 2b8b994 into stanleyfok:master Feb 24, 2018
@colinscape
Copy link
Contributor Author

Thanks so much @stanleyfok - are you planning to publish a new version to npm? Would love to get back onto the 'official' package! 😀

@stanleyfok
Copy link
Owner

1.4.0 is just released with your change :) I have updated the syntax for eslint checking and bumped up version number
e33b080

npm: https://www.npmjs.com/package/kmeans-engine

@colinscape
Copy link
Contributor Author

Amazing! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants