Extend manifests to work properly with kubeadm #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When initializing a local single-node Kubernetes cluster with kubeadm, kube-router is not able to access certaub resources and fails to start. This commit adds a ServiceAccount and a ClusterRoleBinding to the kube-router manifest. This manifest comes from the official kube-router repository: (daemonset/kubeadm-kuberouter-all-features.yaml).
This allows the kubectl checkpoint plugin to create the container checkpoint.
Previously, the curl command could not access the kubelet's client certificate and key.
- Updated with specific instructions for kubeadm - Added instruction to apply the RBAC manifest - Updated the commands of step 9 to run as root - Added a note that the local registry is optional
rst0git
reviewed
Aug 19, 2024
| apiVersion: rbac.authorization.k8s.io/v1 | ||
| kind: ClusterRole | ||
| metadata: | ||
| name: checkpoint-role |
There was a problem hiding this comment.
Would you be able to add more information on how this RBAC role is used with container checkpointing?
There was a problem hiding this comment.
I added a comment on the top of the manifest file.
There was a problem hiding this comment.
It looks like this is fixed in the following pull request:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ServiceAccount and ClusterRoleBinding to the daemonset manifest
When initializing a local single-node Kubernetes cluster with kubeadm, kube-router is not able to access certaub resources and fails to start. This PR adds a ServiceAccount and a ClusterRoleBinding to the kube-router manifest.
This manifest comes from the official kube-router repository
Add checkpoint-rbac.yaml
This allows the kubectl checkpoint plugin to create the container checkpoint.
Run curl with sudo in kubectl-checkpoint
Previously, the curl command could not access the kubelet's client certificate and key.
Update README.md with kubeadm instructions