Merged against master #5
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Speed up tests on Windows
This gives us SNI goodies on all Python versions.
The SNI/subjectAltName tests have a one big problem: They access the great big, bad Internet, because I am not sure how to create the correct certificates for this. Also, this only works in all cases if pyasn1 and ndg-httpsclient are installed (parsing DER-encoded binary data extracted from X.509 extensions is not my idea of fun.)
Travis+tox: Test all the versions.
This makes the SNI-test raise SkipTest if SNI is not supported, so it can be reused by test.contrib.test_pyopenssl even when the stdlib does not support SNI. It also tests the urllib3.contrib.pyopenssl module when its dependencies are installed, by re-exporting HTTPS test-cases and using module-level setup/teardown code to monkey patch urllib3.
Optional PyOpenSSL for SNI-support on Python2.
add fingerprint support to pyopenssl.py
This reverts commit 0f880d5.
Enforce 100% code coverage when testing.
Added Travis status to README.
Prevent passing SSL keywoards to HTTP connection.
Fix coverage for Windows.
Manual specification of hostname to verify against.
Content-Type should be returned as a native string, not a bytestring. This commit ensures that all current tests that exercise the encoding fail on Python 3, where native strings aren't bytestrings.
Content-Type header values should be native strings.
|
Oh, these failing tests are Windows related, I'm seeing them in master, too: urllib3#169 Travis fails only because of missing coverage. |
|
Looks good now: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I merged against master (should be better than rebasing in this case), but there are a few issues with TLS tests.
This is currently a work in progress.