Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(controller): fix dataset link auth error #1013

Merged
merged 3 commits into from
Aug 26, 2022
Merged

Conversation

anda-ren
Copy link
Member

Description

  • support empty auth name
  • convert auth name to uppercase forcefully
  • suppport offset download

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@anda-ren anda-ren added the hotfix 🔥 hotfix bug label Aug 26, 2022
@anda-ren anda-ren added this to the v0.3 milestone Aug 26, 2022
@anda-ren anda-ren self-assigned this Aug 26, 2022
Copy link
Contributor

@jialeicui jialeicui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@jialeicui jialeicui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jialeicui jialeicui merged commit 67bb17c into star-whale:main Aug 26, 2022
@anda-ren anda-ren deleted the it3 branch September 2, 2022 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotfix 🔥 hotfix bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants