Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(controller): evaluation counts include all of jobs #1069

Merged
merged 1 commit into from
Aug 31, 2022
Merged

fix(controller): evaluation counts include all of jobs #1069

merged 1 commit into from
Aug 31, 2022

Conversation

dreamlandliu
Copy link
Contributor

@dreamlandliu dreamlandliu commented Aug 30, 2022 •
edited
Loading

Description

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@dreamlandliu dreamlandliu added the bug 🐛 Something isn't working label Aug 30, 2022
@dreamlandliu dreamlandliu added this to the v0.3 milestone Aug 30, 2022
@dreamlandliu dreamlandliu self-assigned this Aug 30, 2022
goldenxinxing
goldenxinxing approved these changes Aug 30, 2022
View reviewed changes
Copy link
Contributor

@goldenxinxing goldenxinxing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goldenxinxing goldenxinxing merged commit deb089b into star-whale:main Aug 31, 2022
@dreamlandliu dreamlandliu deleted the fix/counts_evaluation_0830 branch January 6, 2023 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goldenxinxing goldenxinxing goldenxinxing approved these changes

Assignees

@dreamlandliu dreamlandliu

Labels
bug 🐛 Something isn't working
Projects
None yet
Milestone
v0.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@dreamlandliu @goldenxinxing