Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dataset): add mask propteries for Dataset Image type #1225

Merged
merged 1 commit into from
Sep 16, 2022

Conversation

tianweidut
Copy link
Member

Description

Modules

  • Python-SDK

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@tianweidut tianweidut added the feature ✨ new feature label Sep 16, 2022
@tianweidut tianweidut added this to the v0.3 milestone Sep 16, 2022
@tianweidut tianweidut self-assigned this Sep 16, 2022
@codecov
Copy link

codecov bot commented Sep 16, 2022

Codecov Report

Merging #1225 (11a7bf3) into main (68216c6) will increase coverage by 11.92%.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##               main    #1225       +/-   ##
=============================================
+ Coverage     69.82%   81.75%   +11.92%     
=============================================
  Files           292       62      -230     
  Lines         13137     6966     -6171     
  Branches        636        0      -636     
=============================================
- Hits           9173     5695     -3478     
+ Misses         3779     1271     -2508     
+ Partials        185        0      -185     
Flag Coverage Δ
controller ?
standalone 81.75% <100.00%> (+0.61%) ⬆️
unittests 81.75% <100.00%> (+0.61%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/starwhale/core/dataset/type.py 99.60% <100.00%> (+17.01%) ⬆️
...whale/mlops/api/protocol/project/StatisticsVo.java
...ain/java/ai/starwhale/mlops/api/protocol/Code.java
...ai/starwhale/mlops/domain/job/cache/JobLoader.java
...hale/mlops/api/protocol/swmp/SwModelPackageVo.java
...arwhale/mlops/exception/ApiOperationException.java
...e/mlops/configuration/json/ObjectMapperConfig.java
...whale/mlops/domain/job/cache/HotJobHolderImpl.java
...java/ai/starwhale/mlops/domain/job/JobService.java
...hale/mlops/domain/job/status/JobStatusMachine.java
... and 222 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@waynelwz waynelwz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tianweidut tianweidut merged commit cafb52b into star-whale:main Sep 16, 2022
@tianweidut tianweidut deleted the feat/mask-image branch September 16, 2022 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants