Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(controller): unit test for swmp controller and convertor #1290

Merged
merged 2 commits into from
Sep 22, 2022

Conversation

dreamlandliu
Copy link
Contributor

@dreamlandliu dreamlandliu commented Sep 22, 2022

Description

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@dreamlandliu dreamlandliu added this to the v0.3 milestone Sep 22, 2022
@dreamlandliu dreamlandliu self-assigned this Sep 22, 2022
@codecov
Copy link

codecov bot commented Sep 22, 2022

Codecov Report

Merging #1290 (529bf63) into main (d24920d) will decrease coverage by 11.70%.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##               main    #1290       +/-   ##
=============================================
- Coverage     73.87%   62.16%   -11.71%     
- Complexity     1212     1235       +23     
=============================================
  Files           288      225       -63     
  Lines         13391     6352     -7039     
  Branches        653      653               
=============================================
- Hits           9892     3949     -5943     
+ Misses         3276     2180     -1096     
  Partials        223      223               
Flag Coverage Δ
controller 62.16% <100.00%> (+1.40%) ⬆️
standalone ?
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../starwhale/mlops/api/SwModelPackageController.java 95.00% <100.00%> (+95.00%) ⬆️
.../ai/starwhale/mlops/domain/swmp/SwmpConvertor.java 100.00% <100.00%> (+100.00%) ⬆️
client/starwhale/utils/debug.py
client/starwhale/mngt/__init__.py
client/starwhale/core/dataset/type.py
client/starwhale/utils/venv_pack.py
client/starwhale/utils/progress.py
client/starwhale/utils/http.py
client/starwhale/core/model/view.py
client/starwhale/base/type.py
... and 59 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@anda-ren anda-ren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@anda-ren anda-ren merged commit 42c219c into star-whale:main Sep 22, 2022
@dreamlandliu dreamlandliu deleted the ut/controller_0922 branch January 6, 2023 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants