Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(e2e):optimise e2e #1320

Merged
merged 17 commits into from
Oct 17, 2022
Merged

Conversation

goldenxinxing
Copy link
Contributor

@goldenxinxing goldenxinxing commented Sep 29, 2022

Description

  1. Replace mnist with simple example in e2e test
  2. replace 'run_demo.sh' with python script
  3. Print the task log regardless of success or failure
  4. fix some tiny bug
  • get_data_loader(): end+1 -> end
  • PipeHandler repeat record ppl/cmp's status
  • add flush option for ppl(an optional that default to false for use in some single-thread unit test without atexit)

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@goldenxinxing goldenxinxing force-pushed the fix/optimise_e2e branch 2 times, most recently from b06690a to 26afc7b Compare September 29, 2022 11:14
@codecov
Copy link

codecov bot commented Sep 29, 2022

Codecov Report

Merging #1320 (92f040a) into main (71d6704) will increase coverage by 5.76%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #1320      +/-   ##
============================================
+ Coverage     79.98%   85.75%   +5.76%     
============================================
  Files           294       64     -230     
  Lines         13903     7275    -6628     
  Branches        696        0     -696     
============================================
- Hits          11121     6239    -4882     
+ Misses         2510     1036    -1474     
+ Partials        272        0     -272     
Flag Coverage Δ
controller ?
standalone 85.75% <100.00%> (+0.02%) ⬆️
unittests 85.75% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/starwhale/api/_impl/dataset/loader.py 100.00% <ø> (ø)
client/starwhale/api/_impl/data_store.py 93.44% <100.00%> (+<0.01%) ⬆️
client/starwhale/api/_impl/model.py 89.92% <100.00%> (+0.22%) ⬆️
...e/mlops/configuration/security/JwtLoginFilter.java
...hale/mlops/domain/bundle/revert/RevertManager.java
...arwhale/mlops/domain/project/ProjectConvertor.java
...i/starwhale/mlops/domain/system/SystemVersion.java
...hale/mlops/domain/system/agent/AgentConverter.java
...e/mlops/domain/evaluation/ViewConfigConvertor.java
...va/ai/starwhale/mlops/domain/task/TaskService.java
... and 224 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@goldenxinxing goldenxinxing changed the title WIP fix(e2e):optimise e2e fix(e2e):optimise e2e Sep 29, 2022
@goldenxinxing goldenxinxing changed the title fix(e2e):optimise e2e WIP fix(e2e):optimise e2e Sep 30, 2022
@goldenxinxing goldenxinxing changed the title WIP fix(e2e):optimise e2e fix(e2e):optimise e2e Oct 12, 2022
@goldenxinxing goldenxinxing changed the title fix(e2e):optimise e2e WIP fix(e2e):optimise e2e Oct 14, 2022
@goldenxinxing goldenxinxing self-assigned this Oct 14, 2022
@goldenxinxing goldenxinxing changed the title WIP fix(e2e):optimise e2e fix(e2e):optimise e2e Oct 17, 2022
Copy link
Member

@anda-ren anda-ren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@anda-ren anda-ren merged commit e797feb into star-whale:main Oct 17, 2022
@goldenxinxing goldenxinxing deleted the fix/optimise_e2e branch April 27, 2023 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants