Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(client): tune runtime process logger with the external swcli verbose setting #1380

Merged
merged 2 commits into from
Oct 18, 2022

Conversation

tianweidut
Copy link
Member

Description

related: #1378

  • realtime output
  • use the external verbose argument for runtime subprocess

image

Modules

  • Client

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@codecov
Copy link

codecov bot commented Oct 17, 2022

Codecov Report

Merging #1380 (e3fa875) into main (e797feb) will decrease coverage by 0.03%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##             main    #1380      +/-   ##
==========================================
- Coverage   85.75%   85.72%   -0.04%     
==========================================
  Files          64       64              
  Lines        7275     7280       +5     
==========================================
+ Hits         6239     6241       +2     
- Misses       1036     1039       +3     
Flag Coverage Δ
standalone 85.72% <83.33%> (-0.04%) ⬇️
unittests 85.72% <83.33%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/starwhale/utils/process.py 79.48% <76.92%> (-6.63%) ⬇️
client/starwhale/consts/__init__.py 100.00% <100.00%> (ø)
client/starwhale/core/runtime/process.py 95.08% <100.00%> (+0.08%) ⬆️
client/starwhale/utils/debug.py 95.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tianweidut tianweidut modified the milestones: v0.3.1, v0.3.0 Oct 18, 2022
Copy link
Contributor

@jialeicui jialeicui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jialeicui jialeicui merged commit 3f1d793 into star-whale:main Oct 18, 2022
@tianweidut tianweidut deleted the enhance/subprocess-log branch April 16, 2023 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants