Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(client): support specifying docker image env in runtime.yaml #1386

Merged
merged 1 commit into from
Oct 18, 2022

Conversation

jialeicui
Copy link
Contributor

Description

Support specifying docker image env in runtime.yaml

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@codecov
Copy link

codecov bot commented Oct 18, 2022

Codecov Report

Merging #1386 (ae53723) into main (78801a4) will increase coverage by 5.77%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #1386      +/-   ##
============================================
+ Coverage     80.00%   85.77%   +5.77%     
============================================
  Files           294       64     -230     
  Lines         13907     7282    -6625     
  Branches        696        0     -696     
============================================
- Hits          11126     6246    -4880     
+ Misses         2509     1036    -1473     
+ Partials        272        0     -272     
Flag Coverage Δ
controller ?
standalone 85.77% <100.00%> (+0.01%) ⬆️
unittests 85.77% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/starwhale/core/runtime/model.py 92.98% <100.00%> (+0.09%) ⬆️
.../ai/starwhale/mlops/domain/user/UserConvertor.java
...ale/mlops/schedule/k8s/ContainerOverwriteSpec.java
...rwhale/mlops/api/protocol/runtime/BaseImageVo.java
...java/ai/starwhale/mlops/domain/dag/DagQuerier.java
...java/ai/starwhale/mlops/datastore/ObjectStore.java
...tarwhale/mlops/domain/job/cache/HotJobsLoader.java
...le/mlops/api/protocol/swds/upload/UploadPhase.java
.../starwhale/mlops/domain/system/agent/bo/Agent.java
...e/mlops/schedule/k8s/K8sResourcePoolConverter.java
... and 221 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@tianweidut tianweidut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tianweidut tianweidut merged commit 49ed268 into star-whale:main Oct 18, 2022
@jialeicui jialeicui deleted the runtime-docker-image branch October 18, 2022 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants