Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(controller): do not expose GPU to the job which requires no GPU #1404

Merged
merged 1 commit into from
Oct 21, 2022

Conversation

jialeicui
Copy link
Contributor

@jialeicui jialeicui commented Oct 21, 2022

Description

Do not expose GPU to the job which requires no GPU

https://docs.nvidia.com/datacenter/cloud-native/container-toolkit/user-guide.html#gpu-enumeration

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@jialeicui jialeicui changed the title chore(controller): do not expose GPU to the job which requires none GPU chore(controller): do not expose GPU to the job which requires no GPU Oct 21, 2022
@jialeicui jialeicui marked this pull request as draft October 21, 2022 06:11
@codecov
Copy link

codecov bot commented Oct 21, 2022

Codecov Report

Merging #1404 (6f5f1ae) into main (94de9f7) will decrease coverage by 6.34%.
The diff coverage is 80.00%.

@@             Coverage Diff              @@
##               main    #1404      +/-   ##
============================================
- Coverage     80.15%   73.80%   -6.35%     
- Complexity     1536     1538       +2     
============================================
  Files           295      230      -65     
  Lines         14008     6636    -7372     
  Branches        696      697       +1     
============================================
- Hits          11228     4898    -6330     
+ Misses         2508     1465    -1043     
- Partials        272      273       +1     
Flag Coverage Δ
controller 73.80% <80.00%> (+<0.01%) ⬆️
standalone ?
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...starwhale/mlops/schedule/k8s/K8sTaskScheduler.java 83.80% <75.00%> (-0.35%) ⬇️
...hale/mlops/schedule/k8s/ResourceOverwriteSpec.java 94.11% <100.00%> (ø)
client/starwhale/utils/cli.py
client/starwhale/utils/flatten.py
client/starwhale/core/runtime/view.py
client/starwhale/utils/process.py
client/starwhale/utils/log.py
client/starwhale/core/runtime/store.py
client/starwhale/base/bundle.py
client/starwhale/utils/docker.py
... and 57 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jialeicui jialeicui marked this pull request as ready for review October 21, 2022 07:45
Copy link
Member

@anda-ren anda-ren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@tianweidut tianweidut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tianweidut tianweidut merged commit 3a30460 into star-whale:main Oct 21, 2022
@jialeicui jialeicui deleted the hide-gpu branch October 21, 2022 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants