Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(unittest): job resource's wrong type #1427

Merged
merged 1 commit into from
Oct 27, 2022

Conversation

goldenxinxing
Copy link
Contributor

@goldenxinxing goldenxinxing commented Oct 27, 2022

Description

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@codecov
Copy link

codecov bot commented Oct 27, 2022

Codecov Report

Merging #1427 (8cfea0e) into main (bf20341) will increase coverage by 5.53%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #1427      +/-   ##
============================================
+ Coverage     80.36%   85.90%   +5.53%     
============================================
  Files           291       65     -226     
  Lines         13937     7384    -6553     
  Branches        689        0     -689     
============================================
- Hits          11201     6343    -4858     
+ Misses         2468     1041    -1427     
+ Partials        268        0     -268     
Flag Coverage Δ
controller ?
standalone 85.90% <ø> (ø)
unittests 85.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...e/mlops/domain/task/converter/TaskBoConverter.java
...ps/storage/env/StorageEnvsPropertiesConverter.java
...n/java/ai/starwhale/mlops/domain/task/bo/Task.java
...hale/mlops/domain/bundle/remove/RemoveManager.java
...starwhale/mlops/domain/job/step/StepConverter.java
...hale/mlops/configuration/SwaggerConfiguration.java
...va/ai/starwhale/mlops/resulting/ResultQuerier.java
...ava/ai/starwhale/mlops/storage/env/StorageEnv.java
...a/ai/starwhale/mlops/datastore/ColumnTypeList.java
...java/ai/starwhale/mlops/storage/env/AliyunEnv.java
... and 216 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@tianweidut tianweidut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tianweidut tianweidut merged commit 5c5b749 into star-whale:main Oct 27, 2022
@goldenxinxing goldenxinxing deleted the fix/job_unit_test_error branch April 27, 2023 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ban-e2e 🚫 bug 🐛 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants