Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add serviceaccount doc in helm install #1437

Merged
merged 1 commit into from
Nov 1, 2022
Merged

doc: add serviceaccount doc in helm install #1437

merged 1 commit into from
Nov 1, 2022

Conversation

jialeicui
Copy link
Contributor

Description

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@jialeicui jialeicui added the doc 📄 Improvements or additions to documentation label Oct 28, 2022
tianweidut
tianweidut approved these changes Nov 1, 2022
View reviewed changes
Copy link
Member

@tianweidut tianweidut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tianweidut tianweidut merged commit 90c42d2 into star-whale:main Nov 1, 2022
@jialeicui jialeicui deleted the rbac-doc branch November 1, 2022 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tianweidut tianweidut tianweidut approved these changes

@xuchuan xuchuan Awaiting requested review from xuchuan

Assignees
No one assigned
Labels
doc 📄 Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jialeicui @tianweidut