Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

example: add emnist dataset #1444

Merged
merged 4 commits into from
Nov 1, 2022
Merged

example: add emnist dataset #1444

merged 4 commits into from
Nov 1, 2022

Conversation

anda-ren
Copy link
Member

@anda-ren anda-ren commented Nov 1, 2022

Description

https://cloud.starwhale.cn/projects/14/datasets/5/versions/22/files
image

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@codecov
Copy link

codecov bot commented Nov 1, 2022

Codecov Report

Merging #1444 (53ddded) into main (27db502) will increase coverage by 5.58%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #1444      +/-   ##
============================================
+ Coverage     80.31%   85.90%   +5.58%     
============================================
  Files           293       65     -228     
  Lines         14034     7385    -6649     
  Branches        696        0     -696     
============================================
- Hits          11272     6344    -4928     
+ Misses         2487     1041    -1446     
+ Partials        275        0     -275     
Flag Coverage Δ
controller ?
standalone 85.90% <ø> (ø)
unittests 85.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...omain/dataset/objectstore/StorageAccessParser.java
...ava/ai/starwhale/mlops/common/util/RandomUtil.java
...hale/mlops/schedule/k8s/ResourceOverwriteSpec.java
.../ai/starwhale/mlops/domain/user/SaltGenerator.java
...rwhale/mlops/domain/task/status/WatchableTask.java
...ai/starwhale/mlops/domain/job/step/StepHelper.java
...va/ai/starwhale/mlops/api/DataStoreController.java
...e/mlops/domain/storage/StoragePathCoordinator.java
...n/java/ai/starwhale/mlops/api/TaskLogWsServer.java
...a/ai/starwhale/mlops/datastore/ColumnTypeList.java
... and 218 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@tianweidut tianweidut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tianweidut tianweidut merged commit 07d299d into star-whale:main Nov 1, 2022
@anda-ren anda-ren deleted the emnist branch December 2, 2022 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants