Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(client): uri refactor #1482

Merged
merged 1 commit into from
Nov 16, 2022
Merged

Conversation

jialeicui
Copy link
Contributor

@jialeicui jialeicui commented Nov 11, 2022

Description

  • Split URI into several parts
    • instance
    • project
    • resource

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@jialeicui jialeicui marked this pull request as draft November 11, 2022 05:31
@codecov
Copy link

codecov bot commented Nov 11, 2022

Codecov Report

Merging #1482 (29ada9a) into main (ffb47da) will increase coverage by 0.33%.
The diff coverage is 97.59%.

@@            Coverage Diff             @@
##             main    #1482      +/-   ##
==========================================
+ Coverage   87.80%   88.14%   +0.33%     
==========================================
  Files          66       70       +4     
  Lines        7797     8003     +206     
==========================================
+ Hits         6846     7054     +208     
+ Misses        951      949       -2     
Flag Coverage Δ
standalone 88.14% <97.59%> (+0.33%) ⬆️
unittests 88.14% <97.59%> (+0.33%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/starwhale/base/uricomponents/instance.py 92.30% <92.30%> (ø)
client/starwhale/base/bundle_copy.py 94.40% <100.00%> (+0.07%) ⬆️
client/starwhale/base/uricomponents/exceptions.py 100.00% <100.00%> (ø)
client/starwhale/base/uricomponents/project.py 100.00% <100.00%> (ø)
client/starwhale/base/uricomponents/resource.py 100.00% <100.00%> (ø)
client/starwhale/api/_impl/dataset/builder.py 88.97% <0.00%> (-0.06%) ⬇️
client/starwhale/api/_impl/dataset/loader.py 99.00% <0.00%> (-0.01%) ⬇️
client/starwhale/api/_impl/dataset/__init__.py 100.00% <0.00%> (ø)
client/starwhale/api/_impl/data_store.py 94.21% <0.00%> (+0.11%) ⬆️
client/starwhale/core/dataset/type.py 100.00% <0.00%> (+0.36%) ⬆️
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jialeicui jialeicui force-pushed the uri-refactor branch 8 times, most recently from 1e32a05 to 77efd70 Compare November 14, 2022 06:56
@jialeicui jialeicui force-pushed the uri-refactor branch 3 times, most recently from 2fd97ea to 24ee448 Compare November 15, 2022 07:51
@jialeicui jialeicui marked this pull request as ready for review November 15, 2022 08:06
Copy link
Member

@tianweidut tianweidut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tianweidut tianweidut merged commit 5946584 into star-whale:main Nov 16, 2022
@jialeicui jialeicui deleted the uri-refactor branch November 17, 2022 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants