Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ut): occasional unit test failure in ParquetReadWriteTest #1520

Merged
merged 1 commit into from
Nov 16, 2022

Conversation

xuchuan
Copy link
Contributor

@xuchuan xuchuan commented Nov 16, 2022

Description

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

Copy link
Contributor

@jialeicui jialeicui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Nov 16, 2022

Codecov Report

Merging #1520 (9640501) into main (0d5b847) will decrease coverage by 5.98%.
The diff coverage is 71.42%.

@@             Coverage Diff              @@
##               main    #1520      +/-   ##
============================================
- Coverage     82.20%   76.21%   -5.99%     
- Complexity     1823     1824       +1     
============================================
  Files           327      257      -70     
  Lines         15923     7925    -7998     
  Branches        852      852              
============================================
- Hits          13089     6040    -7049     
+ Misses         2492     1544     -948     
+ Partials        342      341       -1     
Flag Coverage Δ
controller 76.21% <71.42%> (+0.01%) ⬆️
standalone ?
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...tarwhale/mlops/datastore/parquet/SwOutputFile.java 74.28% <71.42%> (-2.39%) ⬇️
client/starwhale/base/uricomponents/resource.py
client/starwhale/core/model/view.py
client/starwhale/api/_impl/data_store.py
client/starwhale/consts/__init__.py
client/starwhale/core/project/model.py
client/starwhale/utils/http.py
client/starwhale/core/model/model.py
client/starwhale/core/instance/model.py
client/starwhale/core/eval/view.py
... and 62 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@xuchuan xuchuan merged commit 58c4233 into star-whale:main Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants