Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(console): support copy resource url for cli usage in version list page #1527

Merged
merged 1 commit into from
Nov 17, 2022
Merged

feat(console): support copy resource url for cli usage in version list page #1527

merged 1 commit into from
Nov 17, 2022

Conversation

jialeicui
Copy link
Contributor

Description

support copy resource url for cli usage in version list page
copied link like: http://foo.com/projects/3/runtimes/1/versions/1/

cc @tianweidut

image

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@jialeicui jialeicui added the console 🎨 console label Nov 17, 2022
waynelwz
waynelwz approved these changes Nov 17, 2022
View reviewed changes
Copy link
Contributor

@waynelwz waynelwz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM cc @lijing

@waynelwz waynelwz merged commit 75819c6 into star-whale:main Nov 17, 2022
@jialeicui jialeicui deleted the copy-url-web branch November 18, 2022 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waynelwz waynelwz waynelwz approved these changes

@tianweidut tianweidut Awaiting requested review from tianweidut

Assignees
No one assigned
Labels
console 🎨 console
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jialeicui @waynelwz