-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(controller):extract model tar file&remove dataProvider Container #1539
feat(controller):extract model tar file&remove dataProvider Container #1539
Conversation
48668d5
to
6c0ddcb
Compare
Codecov Report
@@ Coverage Diff @@
## main #1539 +/- ##
============================================
+ Coverage 82.45% 82.46% +0.01%
- Complexity 1844 1854 +10
============================================
Files 327 327
Lines 16236 16303 +67
Branches 859 870 +11
============================================
+ Hits 13387 13445 +58
+ Misses 2502 2499 -3
- Partials 347 359 +12
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
6c0ddcb
to
eb9c2a6
Compare
eb9c2a6
to
9a73c40
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add unit tests for ModelService
server/controller/src/main/java/ai/starwhale/mlops/common/TarFileUtil.java
Show resolved
Hide resolved
server/controller/src/main/java/ai/starwhale/mlops/domain/model/ModelService.java
Outdated
Show resolved
Hide resolved
server/controller/src/test/java/ai/starwhale/mlops/common/util/TarUtilTest.java
Outdated
Show resolved
Hide resolved
9bd52f2
to
29ac084
Compare
done |
43b1756
to
1c72eaa
Compare
39addfb
to
ef829c5
Compare
ef829c5
to
df52f1b
Compare
49cc237
to
8b540c7
Compare
server/controller/src/main/java/ai/starwhale/mlops/common/TarFileUtil.java
Show resolved
Hide resolved
server/controller/src/main/java/ai/starwhale/mlops/domain/model/ModelService.java
Show resolved
Hide resolved
...er/src/main/java/ai/starwhale/mlops/domain/task/status/watchers/log/TaskLogK8sCollector.java
Outdated
Show resolved
Hide resolved
server/controller/src/main/java/ai/starwhale/mlops/schedule/k8s/K8sJobTemplate.java
Show resolved
Hide resolved
server/controller/src/main/java/ai/starwhale/mlops/schedule/k8s/K8sTaskScheduler.java
Show resolved
Hide resolved
3d55e99
to
0de352e
Compare
0de352e
to
af70b48
Compare
9b5e7cc
to
2151bf7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Others LGTM
2151bf7
to
1b400c3
Compare
Description
Modules
Checklist