Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(controller):extract model tar file&remove dataProvider Container #1539

Merged
merged 3 commits into from
Nov 27, 2022

Conversation

goldenxinxing
Copy link
Contributor

@goldenxinxing goldenxinxing commented Nov 21, 2022

Description

  • replace initContainer(dataProvider) with copy operation
  • extract model when store to oss
  1. build model at standalone
    image
  2. copy to server
    image
    image
  3. [valid]copy this version from server to standalone(a new name 's-t')
    image
  4. [valid]use list
    image
  5. [valid]use the model of 's-t/v4' to run evaluation
    image

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@goldenxinxing goldenxinxing force-pushed the feat/extract_model_tar branch 3 times, most recently from 48668d5 to 6c0ddcb Compare November 22, 2022 11:58
@goldenxinxing goldenxinxing changed the title WIP feat(controller):extract model tar file feat(controller):extract model tar file Nov 22, 2022
@codecov
Copy link

codecov bot commented Nov 22, 2022

Codecov Report

Merging #1539 (1b400c3) into main (f9cae28) will increase coverage by 0.01%.
The diff coverage is 66.66%.

@@             Coverage Diff              @@
##               main    #1539      +/-   ##
============================================
+ Coverage     82.45%   82.46%   +0.01%     
- Complexity     1844     1854      +10     
============================================
  Files           327      327              
  Lines         16236    16303      +67     
  Branches        859      870      +11     
============================================
+ Hits          13387    13445      +58     
+ Misses         2502     2499       -3     
- Partials        347      359      +12     
Flag Coverage Δ
controller 76.28% <64.55%> (+0.07%) ⬆️
standalone 88.58% <87.50%> (-0.01%) ⬇️
unittests 88.58% <87.50%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/starwhale/core/eval/model.py 77.05% <0.00%> (-0.34%) ⬇️
client/starwhale/core/eval/view.py 70.40% <ø> (ø)
.../ai/starwhale/mlops/domain/model/ModelService.java 69.32% <40.74%> (-4.10%) ⬇️
...i/starwhale/mlops/schedule/k8s/K8sJobTemplate.java 78.94% <62.50%> (-2.75%) ⬇️
...in/java/ai/starwhale/mlops/common/TarFileUtil.java 45.78% <70.37%> (+43.99%) ⬆️
...starwhale/mlops/schedule/k8s/K8sTaskScheduler.java 78.47% <94.11%> (+1.02%) ⬆️
client/starwhale/consts/env.py 100.00% <100.00%> (ø)
client/starwhale/core/eval/executor.py 92.00% <100.00%> (+0.33%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@goldenxinxing goldenxinxing self-assigned this Nov 22, 2022
@goldenxinxing goldenxinxing added the enhancement ❤️ New feature or request label Nov 22, 2022
@goldenxinxing goldenxinxing marked this pull request as ready for review November 22, 2022 12:21
Copy link
Contributor

@xuchuan xuchuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add unit tests for ModelService

@goldenxinxing goldenxinxing force-pushed the feat/extract_model_tar branch 2 times, most recently from 9bd52f2 to 29ac084 Compare November 23, 2022 00:39
@goldenxinxing
Copy link
Contributor Author

Please add unit tests for ModelService

done

@goldenxinxing goldenxinxing changed the title feat(controller):extract model tar file WIP feat(controller):extract model tar file Nov 23, 2022
@goldenxinxing goldenxinxing force-pushed the feat/extract_model_tar branch 4 times, most recently from 43b1756 to 1c72eaa Compare November 23, 2022 07:29
@goldenxinxing goldenxinxing changed the title WIP feat(controller):extract model tar file feat(controller):extract model tar file&remove dataProvider Container Nov 23, 2022
@goldenxinxing goldenxinxing force-pushed the feat/extract_model_tar branch 2 times, most recently from 39addfb to ef829c5 Compare November 23, 2022 10:14
client/scripts/sw-docker-entrypoint Outdated Show resolved Hide resolved
client/scripts/sw-docker-entrypoint Outdated Show resolved Hide resolved
@goldenxinxing goldenxinxing force-pushed the feat/extract_model_tar branch 3 times, most recently from 49cc237 to 8b540c7 Compare November 24, 2022 03:22
@goldenxinxing goldenxinxing force-pushed the feat/extract_model_tar branch 7 times, most recently from 3d55e99 to 0de352e Compare November 24, 2022 11:30
@goldenxinxing goldenxinxing force-pushed the feat/extract_model_tar branch 3 times, most recently from 9b5e7cc to 2151bf7 Compare November 25, 2022 12:26
tianweidut
tianweidut previously approved these changes Nov 26, 2022
Copy link
Member

@tianweidut tianweidut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Others LGTM

@tianweidut tianweidut merged commit ee3dbc5 into star-whale:main Nov 27, 2022
@goldenxinxing goldenxinxing deleted the feat/extract_model_tar branch April 27, 2023 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e enhancement ❤️ New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants