Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(controller): merge migration sql files #1547

Merged
merged 3 commits into from
Nov 24, 2022

Conversation

dreamlandliu
Copy link
Contributor

@dreamlandliu dreamlandliu commented Nov 22, 2022

Description

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@codecov
Copy link

codecov bot commented Nov 23, 2022

Codecov Report

Merging #1547 (87ef619) into main (fb15f3b) will decrease coverage by 6.26%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #1547      +/-   ##
============================================
- Coverage     82.45%   76.18%   -6.27%     
  Complexity     1842     1842              
============================================
  Files           327      257      -70     
  Lines         16204     8012    -8192     
  Branches        858      858              
============================================
- Hits          13361     6104    -7257     
+ Misses         2495     1560     -935     
  Partials        348      348              
Flag Coverage Δ
controller 76.18% <ø> (ø)
standalone ?
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/starwhale/api/metric.py
client/starwhale/base/uricomponents/resource.py
client/starwhale/utils/progress.py
client/starwhale/core/dataset/view.py
client/starwhale/utils/docker.py
client/starwhale/core/dataset/type.py
client/starwhale/base/tag.py
client/starwhale/utils/load.py
client/starwhale/core/instance/model.py
client/starwhale/api/_impl/dataset/builder.py
... and 60 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@goldenxinxing goldenxinxing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goldenxinxing goldenxinxing merged commit 52681d2 into star-whale:main Nov 24, 2022
@dreamlandliu dreamlandliu deleted the feat/flyway_build branch January 6, 2023 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants