Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sdk): support pythonic dataset sdk #1554

Merged
merged 1 commit into from
Dec 3, 2022

Conversation

tianweidut
Copy link
Member

@tianweidut tianweidut commented Nov 24, 2022

Description

Modules

  • Python-SDK

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@tianweidut tianweidut added this to the v0.3.3 milestone Nov 24, 2022
@tianweidut tianweidut self-assigned this Nov 24, 2022
@codecov
Copy link

codecov bot commented Nov 24, 2022

Codecov Report

Merging #1554 (39c17c5) into main (76ee74b) will increase coverage by 8.04%.
The diff coverage is 97.38%.

@@             Coverage Diff              @@
##               main    #1554      +/-   ##
============================================
+ Coverage     81.96%   90.00%   +8.04%     
============================================
  Files           330       71     -259     
  Lines         16505     8734    -7771     
  Branches        910        0     -910     
============================================
- Hits          13528     7861    -5667     
+ Misses         2596      873    -1723     
+ Partials        381        0     -381     
Flag Coverage Δ
controller ?
standalone 90.00% <97.38%> (+1.38%) ⬆️
unittests 90.00% <97.38%> (+1.38%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/starwhale/api/_impl/model.py 91.21% <ø> (+0.54%) ⬆️
client/starwhale/api/dataset.py 100.00% <ø> (ø)
client/starwhale/core/dataset/store.py 95.32% <ø> (+0.89%) ⬆️
client/starwhale/base/tag.py 91.11% <57.14%> (-2.00%) ⬇️
client/starwhale/core/model/view.py 69.38% <60.00%> (+0.31%) ⬆️
client/starwhale/core/model/model.py 84.43% <62.50%> (-0.28%) ⬇️
client/starwhale/core/dataset/view.py 61.90% <75.00%> (+0.79%) ⬆️
client/starwhale/core/runtime/model.py 94.69% <88.88%> (-0.12%) ⬇️
client/starwhale/api/_impl/data_store.py 94.26% <91.66%> (-0.07%) ⬇️
client/starwhale/core/dataset/type.py 98.65% <91.66%> (-0.24%) ⬇️
... and 282 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tianweidut tianweidut force-pushed the feat/dataset-sdk branch 24 times, most recently from bcc13fa to 96ca57c Compare November 30, 2022 03:02
@tianweidut tianweidut changed the title feat(SDK): dataset sdk feat(SDK): support pythonic dataset sdk Nov 30, 2022
@tianweidut tianweidut force-pushed the feat/dataset-sdk branch 3 times, most recently from 4b6bd89 to ecfa85e Compare November 30, 2022 14:57
@tianweidut tianweidut changed the title feat(SDK): support pythonic dataset sdk feat(sdk): support pythonic dataset sdk Dec 1, 2022
anda-ren
anda-ren previously approved these changes Dec 2, 2022
Copy link
Member

@anda-ren anda-ren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

client/starwhale/core/dataset/model.py Outdated Show resolved Hide resolved
client/starwhale/core/model/model.py Outdated Show resolved Hide resolved
Copy link
Contributor

@goldenxinxing goldenxinxing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tianweidut tianweidut merged commit 7c9572a into star-whale:main Dec 3, 2022
@tianweidut tianweidut deleted the feat/dataset-sdk branch April 14, 2023 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants