Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(model): add model diff api for server #1591

Merged

Conversation

goldenxinxing
Copy link
Contributor

@goldenxinxing goldenxinxing commented Dec 7, 2022

Description

  1. tune the response's structure of model info api from flatten list to node list
  2. add model diff api
  3. refactor model download api

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@codecov
Copy link

codecov bot commented Dec 8, 2022

Codecov Report

Merging #1591 (eb62de1) into main (e07a7a6) will increase coverage by 0.00%.
The diff coverage is 75.29%.

@@            Coverage Diff             @@
##               main    #1591    +/-   ##
==========================================
  Coverage     82.66%   82.66%            
- Complexity     1857     1889    +32     
==========================================
  Files           341      342     +1     
  Lines         17678    17788   +110     
  Branches        931      951    +20     
==========================================
+ Hits          14613    14704    +91     
- Misses         2672     2686    +14     
- Partials        393      398     +5     
Flag Coverage Δ
controller 75.04% <75.29%> (+0.09%) ⬆️
standalone 89.74% <ø> (ø)
unittests 89.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/starwhale/core/model/model.py 86.68% <ø> (ø)
...tarwhale/mlops/api/protocol/model/ModelInfoVo.java 0.00% <ø> (ø)
...hale/mlops/api/protocol/runtime/RuntimeInfoVo.java 0.00% <ø> (ø)
...starwhale/mlops/domain/storage/StorageService.java 2.70% <0.00%> (ø)
.../ai/starwhale/mlops/domain/model/ModelService.java 66.66% <60.60%> (+0.30%) ⬆️
...n/java/ai/starwhale/mlops/api/ModelController.java 90.52% <80.00%> (+1.52%) ⬆️
...starwhale/mlops/api/protocol/storage/FileNode.java 85.10% <85.10%> (ø)
...starwhale/mlops/api/protocol/storage/FileDesc.java 100.00% <100.00%> (ø)
...starwhale/mlops/domain/dataset/DatasetService.java 83.33% <100.00%> (ø)
...starwhale/mlops/domain/runtime/RuntimeService.java 71.62% <100.00%> (ø)
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@goldenxinxing goldenxinxing changed the title feat(model): model diff feat(model): add model diff api Dec 8, 2022
@goldenxinxing goldenxinxing self-assigned this Dec 8, 2022
@goldenxinxing goldenxinxing added the break-change 💔 break change label Dec 8, 2022
@goldenxinxing goldenxinxing changed the title feat(model): add model diff api feat(model): add model diff api for server Dec 12, 2022
Copy link
Contributor

@dreamlandliu dreamlandliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@anda-ren anda-ren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@goldenxinxing goldenxinxing merged commit d9a68cb into star-whale:main Dec 14, 2022
@goldenxinxing goldenxinxing deleted the feat/add_list_files_for_model branch April 27, 2023 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants