Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): make test of dataset stable #1592

Merged
merged 2 commits into from
Dec 9, 2022
Merged

Conversation

jialeicui
Copy link
Contributor

@jialeicui jialeicui commented Dec 8, 2022

Description

Fix

FAILED tests/sdk/test_dataset_sdk.py::TestDatasetSDK::test_forbid_handler - OSError: [Errno 39] Directory not empty: '/tmp/sw-test-mock-k6gce_c_'
link

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@codecov
Copy link

codecov bot commented Dec 8, 2022

Codecov Report

Merging #1592 (7aedec4) into main (be68f09) will increase coverage by 7.13%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #1592      +/-   ##
============================================
+ Coverage     82.52%   89.65%   +7.13%     
============================================
  Files           340       77     -263     
  Lines         17461     9013    -8448     
  Branches        930        0     -930     
============================================
- Hits          14410     8081    -6329     
+ Misses         2658      932    -1726     
+ Partials        393        0     -393     
Flag Coverage Δ
controller ?
standalone 89.65% <100.00%> (ø)
unittests 89.65% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/starwhale/utils/fs.py 84.92% <100.00%> (ø)
...configuration/security/ProjectDetectionFilter.java
.../mlops/domain/dataset/po/DatasetVersionEntity.java
...starwhale/mlops/domain/task/status/TaskStatus.java
...ops/api/protocol/runtime/ClientRuntimeRequest.java
...rwhale/mlops/api/protocol/evaluation/ConfigVo.java
...ai/starwhale/mlops/api/protocol/agent/AgentVo.java
.../java/ai/starwhale/mlops/api/SystemController.java
...s/domain/dataset/converter/DatasetVoConverter.java
...ale/mlops/schedule/k8s/ContainerOverwriteSpec.java
... and 254 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tianweidut
Copy link
Member

Others LGTM

@tianweidut tianweidut self-requested a review December 8, 2022 09:38
@jialeicui jialeicui merged commit aa44ee8 into star-whale:main Dec 9, 2022
@jialeicui jialeicui deleted the ds-ut branch December 9, 2022 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants