Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sdk): expand first level of annotations #1612

Merged
merged 2 commits into from
Dec 14, 2022

Conversation

anda-ren
Copy link
Member

Description

expand first level of annotations

Validation

http://ano-expand-20221213.pre.intra.starwhale.ai/
image
image

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@anda-ren anda-ren added this to the v0.3.4 milestone Dec 13, 2022
@anda-ren anda-ren self-assigned this Dec 13, 2022
@codecov
Copy link

codecov bot commented Dec 13, 2022

Codecov Report

Merging #1612 (0326341) into main (f813533) will increase coverage by 7.09%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #1612      +/-   ##
============================================
+ Coverage     82.62%   89.71%   +7.09%     
============================================
  Files           341       78     -263     
  Lines         17598     9151    -8447     
  Branches        931        0     -931     
============================================
- Hits          14540     8210    -6330     
+ Misses         2666      941    -1725     
+ Partials        392        0     -392     
Flag Coverage Δ
controller ?
standalone 89.71% <100.00%> (+0.01%) ⬆️
unittests 89.71% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/starwhale/core/dataset/tabular.py 97.22% <100.00%> (+0.10%) ⬆️
...tarwhale/mlops/common/util/BatchOperateHelper.java
...whale/mlops/domain/job/converter/JobConverter.java
...ava/ai/starwhale/mlops/api/protocol/job/JobVo.java
...java/ai/starwhale/mlops/datastore/OrderByDesc.java
...lops/datastore/parquet/SwParquetReaderBuilder.java
...tarwhale/mlops/domain/system/agent/AgentCache.java
...starwhale/mlops/domain/dataset/DatasetService.java
...autofit/fs/CompatibleStorageAccessServiceFile.java
...ale/mlops/domain/job/converter/JobBoConverter.java
... and 254 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tianweidut tianweidut changed the title feat: expand first level of annotations feat(sdk): expand first level of annotations Dec 14, 2022
Copy link
Member

@tianweidut tianweidut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Others LGTM

@tianweidut tianweidut self-requested a review December 14, 2022 10:14
@tianweidut tianweidut merged commit 02f65c2 into star-whale:main Dec 14, 2022
@anda-ren anda-ren deleted the expd_anno branch January 12, 2023 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants