Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(runtime): support render runtime.yaml in the build runtime progress #1613

Merged
merged 1 commit into from
Dec 15, 2022

Conversation

tianweidut
Copy link
Member

@tianweidut tianweidut commented Dec 13, 2022

Description

Modules

  • Client

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@codecov
Copy link

codecov bot commented Dec 13, 2022

Codecov Report

Merging #1613 (5fa2000) into main (e86de94) will increase coverage by 7.13%.
The diff coverage is 92.10%.

@@             Coverage Diff              @@
##               main    #1613      +/-   ##
============================================
+ Coverage     82.59%   89.72%   +7.13%     
============================================
  Files           341       78     -263     
  Lines         17590     9169    -8421     
  Branches        930        0     -930     
============================================
- Hits          14528     8227    -6301     
+ Misses         2668      942    -1726     
+ Partials        394        0     -394     
Flag Coverage Δ
controller ?
standalone 89.72% <92.10%> (+0.01%) ⬆️
unittests 89.72% <92.10%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/starwhale/core/runtime/model.py 94.68% <85.71%> (-0.19%) ⬇️
client/starwhale/core/runtime/view.py 93.57% <100.00%> (+1.57%) ⬆️
.../starwhale/mlops/schedule/k8s/PodEventHandler.java
...in/java/ai/starwhale/mlops/storage/StorageUri.java
...tarwhale/mlops/common/util/BatchOperateHelper.java
...va/ai/starwhale/mlops/storage/s3/BotoS3Config.java
...n/dataset/converter/DatasetVersionVoConverter.java
...starwhale/mlops/domain/storage/StorageService.java
...hale/mlops/domain/bundle/revert/RevertManager.java
...starwhale/mlops/domain/project/ProjectService.java
... and 256 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@anda-ren anda-ren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tianweidut tianweidut merged commit a57e1b7 into star-whale:main Dec 15, 2022
@tianweidut tianweidut deleted the feat/auto-init-yaml branch April 14, 2023 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants