Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(client): support owner:project instead of project name in uri #1618

Merged
merged 5 commits into from
Dec 15, 2022

Conversation

dreamlandliu
Copy link
Contributor

@dreamlandliu dreamlandliu commented Dec 13, 2022

Description

use owner:project instead of project name in swcli
图片
图片

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@dreamlandliu dreamlandliu added this to the v0.3.4 milestone Dec 13, 2022
@dreamlandliu dreamlandliu self-assigned this Dec 13, 2022
@codecov
Copy link

codecov bot commented Dec 13, 2022

Codecov Report

Merging #1618 (d0b1776) into main (e07a7a6) will increase coverage by 7.10%.
The diff coverage is 100.00%.

❗ Current head d0b1776 differs from pull request most recent head 4536acb. Consider uploading reports for the commit 4536acb to get more accurate results

@@             Coverage Diff              @@
##               main    #1618      +/-   ##
============================================
+ Coverage     82.66%   89.76%   +7.10%     
============================================
  Files           341       78     -263     
  Lines         17678     9245    -8433     
  Branches        931        0     -931     
============================================
- Hits          14613     8299    -6314     
+ Misses         2672      946    -1726     
+ Partials        393        0     -393     
Flag Coverage Δ
controller ?
standalone 89.76% <100.00%> (+0.02%) ⬆️
unittests 89.76% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/starwhale/base/uri.py 96.72% <100.00%> (+0.42%) ⬆️
client/starwhale/core/project/view.py 56.75% <100.00%> (+0.79%) ⬆️
...whale/mlops/api/protocol/upload/UploadRequest.java
...va/ai/starwhale/mlops/storage/util/MetaHelper.java
...ai/starwhale/mlops/api/protocol/trash/TrashVo.java
...it/fs/CompatibleStorageAccessServiceBuilderFs.java
...le/mlops/domain/task/status/TaskStatusMachine.java
...starwhale/mlops/domain/bundle/BundleException.java
...lops/domain/dataset/dataloader/dao/SessionDao.java
...in/java/ai/starwhale/mlops/common/TarFileUtil.java
... and 255 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@tianweidut tianweidut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Others LGTM

@tianweidut tianweidut merged commit 8653105 into star-whale:main Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants