Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

example(dataset): add SVHN dataset #1658

Merged
merged 2 commits into from
Dec 27, 2022
Merged

Conversation

anda-ren
Copy link
Member

Description

image

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@anda-ren anda-ren added this to the v0.3.5 milestone Dec 23, 2022
@anda-ren anda-ren self-assigned this Dec 23, 2022
@codecov
Copy link

codecov bot commented Dec 23, 2022

Codecov Report

Merging #1658 (bffcf32) into main (f207a6c) will increase coverage by 4.26%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #1658      +/-   ##
============================================
+ Coverage     80.53%   84.80%   +4.26%     
============================================
  Files           360       92     -268     
  Lines         19288    10556    -8732     
  Branches        959        0     -959     
============================================
- Hits          15534     8952    -6582     
+ Misses         3354     1604    -1750     
+ Partials        400        0     -400     
Flag Coverage Δ
controller ?
standalone 84.80% <ø> (+<0.01%) ⬆️
unittests 84.80% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../protocol/dataset/upload/DatasetUploadRequest.java
...arwhale/mlops/exception/ApiOperationException.java
...ai/starwhale/mlops/datastore/ColumnTypeObject.java
...lops/datastore/parquet/SwParquetWriterBuilder.java
.../starwhale/mlops/domain/bundle/tag/TagManager.java
...ops/domain/dataset/dataloader/DataReadManager.java
...e/mlops/configuration/security/JwtLoginFilter.java
...whale/mlops/domain/panel/po/PanelPluginEntity.java
...hale/mlops/domain/bundle/revert/RevertManager.java
...n/java/ai/starwhale/mlops/datastore/DataStore.java
... and 260 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tianweidut tianweidut self-requested a review December 27, 2022 04:48
Copy link
Member

@tianweidut tianweidut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tianweidut tianweidut merged commit a75dbc8 into star-whale:main Dec 27, 2022
@anda-ren anda-ren deleted the svhn branch January 12, 2023 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants