Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(controller): add filter params to controller list apis #1683

Merged

Conversation

dreamlandliu
Copy link
Contributor

@dreamlandliu dreamlandliu commented Dec 29, 2022

Description

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@codecov
Copy link

codecov bot commented Dec 29, 2022

Codecov Report

Merging #1683 (59a536d) into main (6efd4a8) will decrease coverage by 7.69%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #1683      +/-   ##
============================================
- Coverage     83.07%   75.37%   -7.70%     
- Complexity     1923     1927       +4     
============================================
  Files           349      270      -79     
  Lines         18309     8822    -9487     
  Branches        969      974       +5     
============================================
- Hits          15210     6650    -8560     
+ Misses         2695     1768     -927     
  Partials        404      404              
Flag Coverage Δ
controller 75.37% <100.00%> (+0.05%) ⬆️
standalone ?
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...java/ai/starwhale/mlops/api/DatasetController.java 80.95% <100.00%> (+0.30%) ⬆️
...n/java/ai/starwhale/mlops/api/ModelController.java 90.62% <100.00%> (+0.09%) ⬆️
...java/ai/starwhale/mlops/api/RuntimeController.java 94.73% <100.00%> (+0.07%) ⬆️
...starwhale/mlops/domain/dataset/DatasetService.java 83.33% <100.00%> (+0.13%) ⬆️
...ale/mlops/domain/dataset/mapper/DatasetMapper.java 88.46% <100.00%> (+0.96%) ⬆️
.../ai/starwhale/mlops/domain/model/ModelService.java 66.76% <100.00%> (+0.09%) ⬆️
...arwhale/mlops/domain/model/mapper/ModelMapper.java 88.46% <100.00%> (+0.96%) ⬆️
...starwhale/mlops/domain/runtime/RuntimeService.java 71.74% <100.00%> (+0.12%) ⬆️
...ale/mlops/domain/runtime/mapper/RuntimeMapper.java 88.46% <100.00%> (+0.96%) ⬆️
...va/ai/starwhale/mlops/domain/user/UserService.java 86.95% <100.00%> (+0.80%) ⬆️
... and 79 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@goldenxinxing goldenxinxing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@goldenxinxing goldenxinxing merged commit 7c97d14 into star-whale:main Dec 29, 2022
@dreamlandliu dreamlandliu deleted the feat/controller_list_filter branch January 6, 2023 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants