Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(controller): remove unused property in model version #2405

Merged

Conversation

goldenxinxing
Copy link
Contributor

@goldenxinxing goldenxinxing commented Jun 26, 2023

Description

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@goldenxinxing goldenxinxing added the chore 🛎️ some tiny change label Jun 26, 2023
@codecov
Copy link

codecov bot commented Jun 26, 2023

Codecov Report

Merging #2405 (6d22621) into main (0717a77) will decrease coverage by 7.34%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##               main    #2405      +/-   ##
============================================
- Coverage     83.71%   76.37%   -7.34%     
+ Complexity     2533     2532       -1     
============================================
  Files           432      332     -100     
  Lines         23450    11795   -11655     
  Branches       1371     1357      -14     
============================================
- Hits          19631     9009   -10622     
+ Misses         3196     2163    -1033     
  Partials        623      623              
Flag Coverage Δ
console ?
controller 76.37% <0.00%> (-0.02%) ⬇️
standalone ?
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...tarwhale/mlops/api/protocol/model/ModelInfoVo.java 0.00% <0.00%> (ø)
.../ai/starwhale/mlops/domain/model/ModelService.java 78.81% <ø> (-0.05%) ⬇️

... and 103 files with indirect coverage changes

@tianweidut tianweidut merged commit eb756ed into star-whale:main Jun 26, 2023
@goldenxinxing goldenxinxing deleted the chore/remove_unused_properties branch June 30, 2023 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore 🛎️ some tiny change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants