Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(controller): add failed reason in task response #2421

Merged
merged 1 commit into from
Jun 29, 2023

Conversation

jialeicui
Copy link
Contributor

@jialeicui jialeicui commented Jun 28, 2023

Description

Add failedReason fied in task list resp (may be null), demo:

{
    "code": "success",
    "message": "Success",
    "data": {
        "total": 2,
        "list": [
            {
                "id": "78",
                "uuid": "f2644658-cb81-46bc-ba22-f29e2ec87029",
                "failedReason":  "ProviderFailed, failed to get instance configs"
            },
...

cc @waynelwz

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@codecov
Copy link

codecov bot commented Jun 28, 2023

Codecov Report

Merging #2421 (43e596c) into main (0b08c2f) will decrease coverage by 7.41%.
The diff coverage is 77.77%.

@@             Coverage Diff              @@
##               main    #2421      +/-   ##
============================================
- Coverage     83.37%   75.97%   -7.41%     
- Complexity     2563     2573      +10     
============================================
  Files           434      334     -100     
  Lines         23650    12003   -11647     
  Branches       1401     1388      -13     
============================================
- Hits          19718     9119   -10599     
+ Misses         3299     2248    -1051     
- Partials        633      636       +3     
Flag Coverage Δ
console ?
controller 75.97% <77.77%> (+0.07%) ⬆️
standalone ?
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...hale/mlops/reporting/SimpleTaskModifyReceiver.java 47.50% <0.00%> (-2.50%) ⬇️
...ale/mlops/domain/task/converter/TaskConverter.java 85.29% <100.00%> (+0.44%) ⬆️
.../starwhale/mlops/schedule/k8s/JobEventHandler.java 65.48% <100.00%> (+1.93%) ⬆️

... and 116 files with indirect coverage changes

Copy link
Contributor

@goldenxinxing goldenxinxing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goldenxinxing goldenxinxing merged commit 35a41eb into star-whale:main Jun 29, 2023
@jialeicui jialeicui deleted the task-failed-reason branch July 3, 2023 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants