Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(controller): header is omitted by response stream #2422

Merged
merged 2 commits into from
Jun 28, 2023

Conversation

anda-ren
Copy link
Member

Description

fix: header is omitted by response stream

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@anda-ren anda-ren added the bug 🐛 Something isn't working label Jun 28, 2023
@anda-ren anda-ren requested a review from jialeicui June 28, 2023 09:55
@codecov
Copy link

codecov bot commented Jun 28, 2023

Codecov Report

Merging #2422 (b8f76b0) into main (bee5ddc) will decrease coverage by 7.45%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #2422      +/-   ##
============================================
- Coverage     83.38%   75.93%   -7.45%     
  Complexity     2565     2565              
============================================
  Files           434      334     -100     
  Lines         23659    11995   -11664     
  Branches       1401     1387      -14     
============================================
- Hits          19728     9109   -10619     
+ Misses         3298     2254    -1044     
+ Partials        633      632       -1     
Flag Coverage Δ
console ?
controller 75.93% <100.00%> (+0.01%) ⬆️
standalone ?
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ale/mlops/domain/storage/HashNamedObjectStore.java 84.21% <ø> (ø)
...java/ai/starwhale/mlops/api/DatasetController.java 82.23% <100.00%> (+0.11%) ⬆️

... and 101 files with indirect coverage changes

Copy link
Contributor

@jialeicui jialeicui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jialeicui jialeicui merged commit 4d395c6 into star-whale:main Jun 28, 2023
@anda-ren anda-ren deleted the fix_header_omitted_stream branch August 11, 2023 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants