Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(client): fix trio typing plugin not found error #2441

Merged
merged 1 commit into from
Jul 3, 2023

Conversation

tianweidut
Copy link
Member

Description

Modules

  • Client

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@tianweidut tianweidut self-assigned this Jul 3, 2023
@tianweidut tianweidut added bug 🐛 Something isn't working client 🌈 and removed chore 🛎️ some tiny change labels Jul 3, 2023
@codecov
Copy link

codecov bot commented Jul 3, 2023

Codecov Report

Merging #2441 (43c61ad) into main (c0c89d6) will increase coverage by 7.47%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #2441      +/-   ##
============================================
+ Coverage     83.42%   90.89%   +7.47%     
============================================
  Files           435       99     -336     
  Lines         23729    11396   -12333     
  Branches       1409        0    -1409     
============================================
- Hits          19795    10358    -9437     
+ Misses         3297     1038    -2259     
+ Partials        637        0     -637     
Flag Coverage Δ
console ?
controller ?
standalone 90.89% <ø> (-0.25%) ⬇️
unittests 90.89% <ø> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 370 files with indirect coverage changes

Copy link
Contributor

@xuchuan xuchuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xuchuan xuchuan merged commit ad27512 into star-whale:main Jul 3, 2023
@tianweidut tianweidut deleted the fix/trio-mypy branch September 5, 2023 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants