Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(console): support job step with need_dataset, system setting full height #2463

Merged
merged 1 commit into from
Jul 5, 2023

Conversation

waynelwz
Copy link
Contributor

@waynelwz waynelwz commented Jul 5, 2023

Description

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@waynelwz waynelwz requested a review from jialeicui July 5, 2023 10:56
@waynelwz waynelwz added enhancement ❤️ New feature or request feature ✨ new feature console 🎨 console labels Jul 5, 2023
@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Merging #2463 (229d4fe) into main (05682d2) will increase coverage by 3.58%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #2463      +/-   ##
============================================
+ Coverage     76.17%   79.76%   +3.58%     
============================================
  Files           335        1     -334     
  Lines         12083       84   -11999     
  Branches       1398       14    -1384     
============================================
- Hits           9204       67    -9137     
+ Misses         2247       17    -2230     
+ Partials        632        0     -632     
Flag Coverage Δ
console 79.76% <ø> (?)
controller ?
unittests 79.76% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 336 files with indirect coverage changes

Copy link
Contributor

@jialeicui jialeicui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jialeicui jialeicui merged commit 6329be7 into star-whale:main Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
console 🎨 console enhancement ❤️ New feature or request feature ✨ new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants