Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(console): add confirm when cancelling or pausing tasks #2495

Merged
merged 2 commits into from
Jul 11, 2023

Conversation

jialeicui
Copy link
Contributor

Description

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@jialeicui jialeicui added chore 🛎️ some tiny change console 🎨 console labels Jul 11, 2023
@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Merging #2495 (074687e) into main (db0884c) will decrease coverage by 3.76%.
The diff coverage is n/a.

❗ Current head 074687e differs from pull request most recent head 5949d18. Consider uploading reports for the commit 5949d18 to get more accurate results

@@             Coverage Diff              @@
##               main    #2495      +/-   ##
============================================
- Coverage     83.51%   79.76%   -3.76%     
============================================
  Files           436        1     -435     
  Lines         23858       84   -23774     
  Branches       1417       14    -1403     
============================================
- Hits          19925       67   -19858     
+ Misses         3298       17    -3281     
+ Partials        635        0     -635     
Flag Coverage Δ
console 79.76% <ø> (ø)
controller ?
standalone ?
unittests 79.76% <ø> (-11.36%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 435 files with indirect coverage changes

Copy link
Contributor

@waynelwz waynelwz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@waynelwz waynelwz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@waynelwz waynelwz merged commit 6342de4 into star-whale:main Jul 11, 2023
@jialeicui jialeicui deleted the cancel-confirm branch July 11, 2023 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore 🛎️ some tiny change console 🎨 console
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants