Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(controller): run log save doesn't break status report #2994

Merged
merged 1 commit into from
Nov 17, 2023

Conversation

anda-ren
Copy link
Member

Description

  1. run log save doesn't break status report
  2. add retry for run log saving

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

Copy link

codecov bot commented Nov 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6b29a60) 82.45% compared to head (6867ba4) 73.29%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2994      +/-   ##
============================================
- Coverage     82.45%   73.29%   -9.17%     
- Complexity     3110     3118       +8     
============================================
  Files           563      436     -127     
  Lines         30336    15181   -15155     
  Branches       1825     1764      -61     
============================================
- Hits          25015    11127   -13888     
+ Misses         4516     3247    -1269     
- Partials        805      807       +2     
Flag Coverage Δ
console ?
controller 73.29% <100.00%> (+0.03%) ⬆️
standalone ?
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anda-ren anda-ren marked this pull request as ready for review November 17, 2023 06:35
Copy link
Contributor

@jialeicui jialeicui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jialeicui jialeicui merged commit f9282b1 into star-whale:main Nov 17, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants