Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(client): question answering infer type support multiple args #2997

Merged
merged 2 commits into from
Nov 22, 2023

Conversation

jialeicui
Copy link
Contributor

Description

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@jialeicui jialeicui added enhancement ❤️ New feature or request client 🌈 labels Nov 20, 2023
@jialeicui jialeicui marked this pull request as draft November 20, 2023 08:35
Copy link

codecov bot commented Nov 20, 2023

Codecov Report

Attention: 21 lines in your changes are missing coverage. Please review.

Comparison is base (4d2db61) 82.51% compared to head (4d22c06) 91.95%.
Report is 12 commits behind head on main.

Files Patch % Lines
client/starwhale/api/_impl/service/types/types.py 64.10% 14 Missing ⚠️
client/starwhale/api/_impl/service/types/llm.py 85.29% 5 Missing ⚠️
client/starwhale/api/_impl/service/service.py 88.23% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2997      +/-   ##
============================================
+ Coverage     82.51%   91.95%   +9.44%     
============================================
  Files           563      126     -437     
  Lines         30353    15033   -15320     
  Branches       1826        0    -1826     
============================================
- Hits          25045    13824   -11221     
+ Misses         4503     1209    -3294     
+ Partials        805        0     -805     
Flag Coverage Δ
console ?
controller ?
standalone 91.95% <77.17%> (-0.09%) ⬇️
unittests 91.95% <77.17%> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jialeicui jialeicui marked this pull request as ready for review November 20, 2023 08:58
@tianweidut
Copy link
Member

Others LGTM

@tianweidut tianweidut merged commit 4497e3f into star-whale:main Nov 22, 2023
38 checks passed
@jialeicui jialeicui deleted the qa-component branch November 22, 2023 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client 🌈 enhancement ❤️ New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants