Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(controller): fix multiple same env on console #3014

Merged
merged 2 commits into from
Nov 22, 2023

Conversation

anda-ren
Copy link
Member

@anda-ren anda-ren commented Nov 22, 2023

Description

cc @waynelwz

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

Copy link

codecov bot commented Nov 22, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (4497e3f) 82.71% compared to head (ae72ec6) 73.72%.
Report is 1 commits behind head on main.

Files Patch % Lines
.../starwhale/mlops/domain/ft/FineTuneAppService.java 91.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3014      +/-   ##
============================================
- Coverage     82.71%   73.72%   -9.00%     
- Complexity     3126     3127       +1     
============================================
  Files           557      428     -129     
  Lines         30426    15188   -15238     
  Branches       1831     1771      -60     
============================================
- Hits          25167    11197   -13970     
+ Misses         4449     3181    -1268     
  Partials        810      810              
Flag Coverage Δ
console ?
controller 73.72% <91.66%> (+0.02%) ⬆️
standalone ?
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anda-ren anda-ren marked this pull request as ready for review November 22, 2023 07:53
Copy link
Contributor

@goldenxinxing goldenxinxing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goldenxinxing goldenxinxing merged commit 314934e into star-whale:main Nov 22, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants