Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(controller): move handler to user job request #3021

Merged
merged 6 commits into from
Nov 24, 2023

Conversation

anda-ren
Copy link
Member

Description

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

Copy link

codecov bot commented Nov 23, 2023

Codecov Report

Attention: 23 lines in your changes are missing coverage. Please review.

Comparison is base (c3fc2c7) 82.73% compared to head (18ddf67) 73.77%.
Report is 3 commits behind head on main.

Files Patch % Lines
...e/mlops/domain/job/converter/UserJobConverter.java 55.26% 14 Missing and 3 partials ⚠️
...java/ai/starwhale/mlops/domain/job/JobCreator.java 0.00% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3021      +/-   ##
============================================
- Coverage     82.73%   73.77%   -8.96%     
- Complexity     3146     3147       +1     
============================================
  Files           558      429     -129     
  Lines         30586    15339   -15247     
  Branches       1834     1774      -60     
============================================
- Hits          25306    11317   -13989     
+ Misses         4470     3214    -1256     
+ Partials        810      808       -2     
Flag Coverage Δ
console ?
controller 73.77% <51.06%> (-0.07%) ⬇️
standalone ?
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anda-ren anda-ren added the e2e label Nov 23, 2023
@anda-ren anda-ren changed the title WIP refactor(controller): move handler to user job request refactor(controller): move handler to user job request Nov 23, 2023
@anda-ren anda-ren requested review from jialeicui and goldenxinxing and removed request for jialeicui November 23, 2023 11:38
@anda-ren anda-ren marked this pull request as ready for review November 23, 2023 11:38
Copy link
Contributor

@jialeicui jialeicui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goldenxinxing goldenxinxing merged commit 1a05091 into star-whale:main Nov 24, 2023
21 checks passed
@anda-ren anda-ren deleted the refactor/job_creator branch November 24, 2023 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants