Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(controller): fix user input duplicate env error when finetuning #3023

Merged
merged 1 commit into from
Nov 23, 2023

Conversation

anda-ren
Copy link
Member

Description

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

Copy link

codecov bot commented Nov 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c3fc2c7) 82.73% compared to head (4b76fd0) 73.84%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3023      +/-   ##
============================================
- Coverage     82.73%   73.84%   -8.90%     
- Complexity     3146     3148       +2     
============================================
  Files           558      429     -129     
  Lines         30586    15337   -15249     
  Branches       1834     1773      -61     
============================================
- Hits          25306    11325   -13981     
+ Misses         4470     3203    -1267     
+ Partials        810      809       -1     
Flag Coverage Δ
console ?
controller 73.84% <100.00%> (-0.01%) ⬇️
standalone ?
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anda-ren anda-ren marked this pull request as ready for review November 23, 2023 08:47
@goldenxinxing goldenxinxing merged commit 68bf422 into star-whale:main Nov 23, 2023
17 checks passed
@anda-ren anda-ren deleted the fix_merge_dup branch November 23, 2023 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants