Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix(controller): create table if not exist when sync eval table #3060

Conversation

goldenxinxing
Copy link
Contributor

@goldenxinxing goldenxinxing commented Dec 6, 2023

Description

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@goldenxinxing goldenxinxing added the bug 🐛 Something isn't working label Dec 6, 2023
@goldenxinxing goldenxinxing self-assigned this Dec 6, 2023
Copy link

codecov bot commented Dec 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (617b20f) 82.78% compared to head (947f5b2) 73.91%.
Report is 2 commits behind head on main.

❗ Current head 947f5b2 differs from pull request most recent head 4f2727a. Consider uploading reports for the commit 4f2727a to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3060      +/-   ##
============================================
- Coverage     82.78%   73.91%   -8.87%     
+ Complexity     3168     3167       -1     
============================================
  Files           566      431     -135     
  Lines         31301    15439   -15862     
  Branches       1789     1789              
============================================
- Hits          25911    11412   -14499     
+ Misses         4573     3209    -1364     
- Partials        817      818       +1     
Flag Coverage Δ
controller 73.91% <100.00%> (-0.02%) ⬇️
standalone ?
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jialeicui jialeicui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jialeicui jialeicui merged commit de5e14d into star-whale:main Dec 6, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants