Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(datastore): support upload using the new api #3071

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jialeicui
Copy link
Contributor

@jialeicui jialeicui commented Dec 7, 2023

Description

depends on #3064

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@jialeicui jialeicui marked this pull request as draft December 7, 2023 11:16
Copy link

codecov bot commented Dec 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f5cce0c) 82.62% compared to head (b25ed0e) 73.50%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3071      +/-   ##
============================================
- Coverage     82.62%   73.50%   -9.13%     
+ Complexity     3205     3204       -1     
============================================
  Files           571      433     -138     
  Lines         31761    15649   -16112     
  Branches       1872     1812      -60     
============================================
- Hits          26243    11503   -14740     
+ Misses         4694     3323    -1371     
+ Partials        824      823       -1     
Flag Coverage Δ
console ?
controller 73.50% <ø> (+0.02%) ⬆️
standalone ?
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant