Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(client): support to detect shell activated runtime uri for model build #3086

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

tianweidut
Copy link
Member

Description

Modules

  • Client

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

Copy link

codecov bot commented Dec 15, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (4247130) 82.60% compared to head (01583ee) 91.85%.

Files Patch % Lines
client/starwhale/core/runtime/process.py 93.10% 2 Missing ⚠️
client/starwhale/utils/venv.py 87.50% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3086      +/-   ##
============================================
+ Coverage     82.60%   91.85%   +9.25%     
============================================
  Files           571      135     -436     
  Lines         31789    15959   -15830     
  Branches       1873        0    -1873     
============================================
- Hits          26258    14659   -11599     
+ Misses         4707     1300    -3407     
+ Partials        824        0     -824     
Flag Coverage Δ
console ?
controller ?
standalone 91.85% <92.85%> (+0.07%) ⬆️
unittests 91.85% <92.85%> (+0.33%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tianweidut tianweidut marked this pull request as draft December 15, 2023 10:53
@tianweidut tianweidut marked this pull request as ready for review December 15, 2023 11:22
Copy link
Contributor

@goldenxinxing goldenxinxing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goldenxinxing goldenxinxing merged commit b19f8b2 into star-whale:main Dec 19, 2023
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants