Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(console): use current web host in quickstart for model #3087

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

jialeicui
Copy link
Contributor

@jialeicui jialeicui commented Dec 18, 2023

Description

image

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

Copy link

codecov bot commented Dec 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4247130) 82.60% compared to head (688f275) 72.09%.

Additional details and impacted files
@@              Coverage Diff              @@
##               main    #3087       +/-   ##
=============================================
- Coverage     82.60%   72.09%   -10.51%     
=============================================
  Files           571        3      -568     
  Lines         31789      215    -31574     
  Branches       1873       61     -1812     
=============================================
- Hits          26258      155    -26103     
+ Misses         4707       58     -4649     
+ Partials        824        2      -822     
Flag Coverage Δ
console 72.09% <ø> (ø)
controller ?
standalone ?
unittests 72.09% <ø> (-19.43%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jialeicui jialeicui added chore 🛎️ some tiny change console 🎨 console labels Dec 18, 2023
Copy link
Contributor

@waynelwz waynelwz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@waynelwz waynelwz merged commit f521971 into star-whale:main Dec 19, 2023
17 checks passed
@jialeicui jialeicui deleted the console-quickstart branch December 19, 2023 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore 🛎️ some tiny change console 🎨 console
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants