Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(controller): prevent access to deleted projects #3112

Merged
merged 1 commit into from
Jan 5, 2024

Conversation

jialeicui
Copy link
Contributor

Description

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

Copy link

codecov bot commented Jan 4, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (2ce80aa) 82.68% compared to head (b1de335) 73.41%.
Report is 1 commits behind head on main.

Files Patch % Lines
...e/mlops/configuration/security/JwtTokenFilter.java 83.33% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3112      +/-   ##
============================================
- Coverage     82.68%   73.41%   -9.27%     
- Complexity     3181     3185       +4     
============================================
  Files           575      433     -142     
  Lines         32062    15638   -16424     
  Branches       1865     1805      -60     
============================================
- Hits          26510    11481   -15029     
+ Misses         4726     3334    -1392     
+ Partials        826      823       -3     
Flag Coverage Δ
console ?
controller 73.41% <83.33%> (+0.07%) ⬆️
standalone ?
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@anda-ren anda-ren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anda-ren anda-ren merged commit e30c32c into star-whale:main Jan 5, 2024
17 checks passed
@jialeicui jialeicui deleted the deleted-project branch January 5, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants