Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add custom args #3117

Merged
merged 19 commits into from
Jan 12, 2024
Merged

Conversation

goldenxinxing
Copy link
Contributor

@goldenxinxing goldenxinxing commented Jan 9, 2024

Description

  1. write arguments spec to job.yaml
  2. support parse arguments in server side
  3. output the failed log in githua action

Modules

  • UI
  • Controller
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@goldenxinxing goldenxinxing force-pushed the feat/add-custom-args branch 2 times, most recently from f3d0cf9 to b229d9f Compare January 9, 2024 03:42
Copy link

codecov bot commented Jan 9, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (cd671cb) 91.60% compared to head (a48d6c2) 82.95%.

Files Patch % Lines
.../impl/SwCliModelHandlerContainerSpecification.java 86.66% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3117      +/-   ##
============================================
- Coverage     91.60%   82.95%   -8.66%     
- Complexity        0     3193    +3193     
============================================
  Files           142      572     +430     
  Lines         16442    31910   +15468     
  Branches         61     1812    +1751     
============================================
+ Hits          15062    26471   +11409     
- Misses         1378     4612    +3234     
- Partials          2      827     +825     
Flag Coverage Δ
console ?
controller 73.45% <86.66%> (?)
standalone 92.10% <100.00%> (+0.24%) ⬆️
unittests 92.10% <100.00%> (+0.50%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@goldenxinxing goldenxinxing force-pushed the feat/add-custom-args branch 2 times, most recently from 6abf534 to 15c1791 Compare January 9, 2024 07:31
@goldenxinxing goldenxinxing marked this pull request as ready for review January 9, 2024 08:52
@goldenxinxing goldenxinxing changed the title feat(controller): add custom args feat: add custom args Jan 9, 2024
@tianweidut
Copy link
Member

Others LGTM

@tianweidut tianweidut merged commit 58d69b9 into star-whale:main Jan 12, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants