Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update(console): editor bubble menu invalid when readonly & header dropdown zindex #3118

Merged
merged 2 commits into from
Jan 9, 2024

Conversation

waynelwz
Copy link
Contributor

@waynelwz waynelwz commented Jan 9, 2024

Description

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

Copy link

codecov bot commented Jan 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (554441f) 82.83% compared to head (21403f7) 72.09%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@              Coverage Diff              @@
##               main    #3118       +/-   ##
=============================================
- Coverage     82.83%   72.09%   -10.75%     
=============================================
  Files           575        3      -572     
  Lines         32075      215    -31860     
  Branches       1866       61     -1805     
=============================================
- Hits          26570      155    -26415     
+ Misses         4680       58     -4622     
+ Partials        825        2      -823     
Flag Coverage Δ
console 72.09% <ø> (ø)
controller ?
standalone ?
unittests 72.09% <ø> (-19.72%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jialeicui jialeicui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jialeicui jialeicui merged commit 443bfcd into star-whale:main Jan 9, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants